Ensure Recursor sends requrests without the rd flag set

alexdalitz / dnsruby

Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project

Other

194 stars 77 forks source link

Ensure Recursor sends requrests without the rd flag set #174

Closed seandilda closed 3 years ago

seandilda commented 3 years ago

While tracking down an issue with failed recursive lookups, wireshark analysis determined that the requests were being sent with the 'rd' flag even though the docs for Dnsruby::Recursor shows that should not be the case.

This patch ensures the rd flag is not set on these requests.

alexdalitz commented 3 years ago

Oh dear - I can only apologise for the time you've spent tracking this down, and thank you most sincerely for the patch!

Would it help if I released a new gem with this?

seandilda commented 3 years ago

No worries on the time tracking it down. It wasn't that long.

A new gem release would be great. Thanks!

alexdalitz commented 3 years ago

I've just released v1.61.6