Don't muddle up cflags and ldflags

alexdantas / nSnake

The classic snake game with textual interface

http://nsnake.alexdantas.net

GNU General Public License v3.0

199 stars 57 forks source link

Don't muddle up cflags and ldflags #12

Closed cicku closed 10 years ago

cicku commented 10 years ago

CFLAGS != LDFLAGS, using PLATFORM as global is bad.

Also for that bin file, well, /usr/bin is pretty common now, I don't know why some distros still prefer /usr/games.

DESTDIR != PREFIX, please do NOT put them together

alexdantas commented 10 years ago

Thanks a lot for this contribution!

I agree on the /usr/bin thing; it was only there because of Debian but since a lot of distros don't use /usr/games, I might simply provide a patch when packaging there.
I must have got a little confused on the DESTDIR/PREFIX thing, but shouldn't PREFIX be /usr/local instead of /usr? Anyway I'll merge this in and change later if necessary.

cicku commented 10 years ago

PREFIX is something like /usr, /usr/local. There is no guideline about which one is better, the GNU doc only cares about the distros with /usr/local, but what about others? You may write this:

PREFIX ?= /usr/local

as default.

DESTDIR is the destination place, the default should be empty, people can specify what they want by manually passing argument on the command during the make process.

alexdantas commented 10 years ago

Good call.

I will stick to /usr/local in favor of people installing from source - don't want to mix locally installed binaries with system ones. But of course, personal preference and stuff.

Again, thanks for the contribution and for maintaining it on Fedora!