search

alexdebril / feed-io

A PHP library to read and write feeds in JSONFeed, RSS or Atom format
https://alexdebril.github.io/feed-io/
MIT License
256 stars 54 forks source link

feed-io produces invalid RSS feeds #171

Closed alexdebril closed 6 years ago

alexdebril commented 6 years ago

following https://github.com/alexdebril/rss-atom-bundle/issues/170

feed-io produces invalid feeds as we can see through https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Frss-atom-demo.herokuapp.com%2Frss%2Fmock

main errors are :

Other validation problems may be added in the following issue.

alexdebril commented 6 years ago

RSS Feeds are now valid : https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Frss-atom-demo.herokuapp.com%2Frss%2Fmock https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fdebril.org%2Frss

cf-nsousa commented 6 years ago

Sorry but feeds are not valid again: https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Frss-atom-demo.herokuapp.com%2Frss%2Fmock

alexdebril commented 6 years ago

the demo is not up to date with the last feed-io release. Try with a fresh project, you'll have an accurate result.

I see that I didn't paste the good link, this one is valid : https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fdebril.org%2Frss

cf-nsousa commented 6 years ago

Oh ok my bad then ;) Unfortunately, I can't have the latest build since our project is not PHP7+ yet :/ Just by chance, do you know a way to make v4.1.1 valid without Forking and making changes xD Problems are the same as the link: https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Frss-atom-demo.herokuapp.com%2Frss%2Fmock

alexdebril commented 6 years ago

no problem, I corrected my comment :)

I can backport the fix to the 3.x branch of feed-io as it is supported until the end of php 5.6. Just to be sure, you're using feed-io through rss-atom-bundle in a Symfony project ?

cf-nsousa commented 6 years ago

No, I'm using both separately, I can update only feed-io if needed ;)

alexdebril commented 6 years ago

ok, great I will release it in the next few days. I'll tell you when it's ready :)

cf-nsousa commented 6 years ago

Nice, thanks ;) I'll await your call then :)

alexdebril commented 6 years ago

Hi @cf-nsousa

The fix is now available in v3.1.1 !

Sorry for the delay

cf-nsousa commented 6 years ago

Hi @alexdebril , Thank you!

No problem really ;)