search

alexdebril / rss-atom-bundle

RSS and Atom Bundle for Symfony
MIT License
139 stars 49 forks source link

Undefined method getParameter in StreamController (since 4.2.2) #185

Closed homarx closed 5 years ago

homarx commented 5 years ago

Since AbstractController is used in StreamController (instead of Controller) feed generating breaks with error "Undefined method getParameter in StreamController.php 159". Even the default MockProvider doesn't work anymore.

When downgrading to v4.2.1 feed is generated as expected.

alexdebril commented 5 years ago

ok, thanks for the feedback. Shortly, the StreamController won't call getParameter anymore

alexdebril commented 5 years ago

Which version of Symfony are you using ? Because I don't think it breaks for all versions, otherwise it would have been blocked by unit tests

homarx commented 5 years ago

I use Symfony version 3.4.30

alexdebril commented 5 years ago

Probably fixed in 4.3, could you confirm ? (I mostly use Sf 4.x for my tests)

homarx commented 5 years ago

I upgraded to 5.0.1, adapted my custom provider and everything works! Thanks for your work Alex

alexdebril commented 5 years ago

Cool, thanks for your feedback! Speaking of the new provider, what do you think of the new interface?

homarx commented 5 years ago

To be honest; I only took a look at the MockProvider to see what I have to change in my custom provider getting things work : )

alexdebril commented 5 years ago

Well, at least it's working! 😀 Thanks again for your time, I close the issue