search

alexdebril / rss-atom-bundle

RSS and Atom Bundle for Symfony
MIT License
139 stars 49 forks source link

Type error in ModifiedSince #208

Closed bezin closed 2 years ago

bezin commented 2 years ago

Hi there,

first of all thank you for providing this bundle! I am trying to implement it into Contao CMS, but ran into some issues:

Debril\RssAtomBundle\Request\ModifiedSince::getModifiedSince(): Argument #1 ($request) must be of type Symfony\Component\HttpFoundation\Request, null given, called in [redacted]/vendor/debril/rss-atom-bundle/src/Request/ModifiedSince.php on line 22

This happens on cache warming, because than $this->requestStack->getCurrentRequest() always returns null. This also happens in any cli command I tried.

I use the latest version of the bundle with Symfony 5.4

alexdebril commented 2 years ago

thanks! it's released in v5.1.3

bezin commented 2 years ago

Thanks a lot for reacting so quickly 🚀