search

alexdebril / rss-atom-bundle

RSS and Atom Bundle for Symfony
MIT License
139 stars 49 forks source link

Fatal Error in StreamController on line 136 #55

Closed maedchenflohmarkt closed 9 years ago

maedchenflohmarkt commented 9 years ago

After updating to Symfony 2.6 the bundle throws a PHP Fatal Error in the StreamController:

PHP Fatal error:  Cannot instantiate interface Symfony\Component\OptionsResolver\Options in /[...]/vendor/debril/rss-atom-bundle/Debril/RssAtomBundle/Controller/StreamController.php on line 136

Apparently Options is now an interface which cannot be instantiated. The class OptionsResolver in namespace Symfony\Component\OptionsResolver seems to be the default implementation. Maybe this class should be used instead.

alexdebril commented 9 years ago

Your proposal must be right, but we need to check if the code will still work with Symfony 2.4 and 2.5.

alexdebril commented 9 years ago

The OptionsResolver is a good idea, it will be compatible with every versions of the framework.

But it will break compatibility in the FeedContentProvider interface, so I wlll correct this bug in a new version called 1.5.

alexdebril commented 9 years ago

Some news about this fix : https://blog.debril.fr/category/rss-atom-bundle

alexdebril commented 9 years ago

I just released a beta preview for the 1.5 version, could you test it and tell me if it breaks anything in your project please ?

maedchenflohmarkt commented 9 years ago

We are just now back from the holidays.

The 1.5 beta works without any issues on our setup. It needs a small change in the FeedProvider (since the interface changed) so it is not compatible with ~1.3 anymore but I don't see an easy way around this.