search

alexdeyneka / spring-mvc-service

The project is based on Spring MVC framework where *.jsp files are used as views. Service uses another application controller's endpoints via RestTemplate
0 stars 0 forks source link

Review #1 (13/11/2019) - last commit: cd522c1 #1

Open LatsykNS opened 4 years ago

LatsykNS commented 4 years ago

  1. Modify ReadME.MD How to make good ReadME.MD https://www.makeareadme.com/ https://gist.github.com/PurpleBooth/109311bb0361f32d87a2

  2. Create a .gitignore file for project https://www.gitignore.io/ And you can apply plugin in IntelliJ IDEA

  3. Project bug fix

  4. Unit / integration tests

  5. Create separate services for restTemplate calls

  6. For building restTemplate object use 'Builder pattern'

  7. Move ProductDTO from folder 'entity' to folder 'model'

  8. Remove market service dependency

  9. Divide controlle into: auth, product

  10. Change the name of Service to more functional

alexdeyneka commented 4 years ago

Thanks for the analysis. Code is ready for review