search

alexdlaird / pyngrok

A Python wrapper for ngrok
https://pyngrok.readthedocs.io
MIT License
421 stars 59 forks source link

Creating a tunnel with option bind_tls enabled returns an http URL #62

Closed alfozan closed 4 years ago

alfozan commented 4 years ago

Describe the Bug Creating a tunnel with option bind_tls enabled returns an http URL instead of an https URL

Steps to Reproduce

from pyngrok import ngrok

# Open an HTTPs tunnel on port 5000 for http://localhost:5000
public_url = ngrok.connect(port="5000", proto="http", options={"bind_tls": True})
print(public_url)

Output: http://abc.ngrok.io

Expected Behavior https://abc.ngrok.io

Environment PYNGROK VERSION: 4.1.9 VERSION: 2.3.35

Env: https://colab.research.google.com/

Additional Context current mitigation: print(public_url.replace("http:", "https:"))

and thank you for this nice and handy library! 🙏

Update: Bug fix PR: https://github.com/alexdlaird/pyngrok/pull/63

alexdlaird commented 4 years ago

Resolved in 4.1.10, which will be available on PyPI shortly.

alfozan commented 4 years ago

Resolved in 4.1.10, which will be available on PyPI shortly.

Thanks; just tested on colab and current version has the fix.