Closed alfozan closed 4 years ago
Merging #63 into master will decrease coverage by
1.22%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 95.51% 94.29% -1.23%
==========================================
Files 5 5
Lines 491 491
==========================================
- Hits 469 463 -6
- Misses 22 28 +6
Impacted Files | Coverage Δ | |
---|---|---|
pyngrok/ngrok.py | 92.91% <100.00%> (-0.79%) |
:arrow_down: |
pyngrok/process.py | 92.34% <0.00%> (-2.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fb26bfb...b839fb7. Read the comment docs.
Trying to remember if there was a reason I specifically didn't do this ... can't think of anything at present.
Could you add a unit test to assert the public_url
is properly asserted as https
? There should be similar ones you can base it off of. Thanks!
Description Fix bug reported in https://github.com/alexdlaird/pyngrok/issues/62
Issues https://github.com/alexdlaird/pyngrok/issues/62
Test plan:
output: https://X.ngrok.io prefix is
https
as expectedother use cases are not affected:
output: http://X.ngrok.io
output: http://X.ngrok.io
All outputs are as expected
Environment:
Tested on: https://colab.research.google.com/
Type of Change
Checklist