Closed alexdlaird closed 3 years ago
Merging #69 into develop will decrease coverage by
0.45%
. The diff coverage is93.71%
.
@@ Coverage Diff @@
## develop #69 +/- ##
===========================================
- Coverage 94.72% 94.27% -0.46%
===========================================
Files 5 5
Lines 512 559 +47
===========================================
+ Hits 485 527 +42
- Misses 27 32 +5
Impacted Files | Coverage Δ | |
---|---|---|
pyngrok/process.py | 93.20% <91.89%> (-1.70%) |
:arrow_down: |
pyngrok/ngrok.py | 92.26% <91.95%> (+0.59%) |
:arrow_up: |
pyngrok/conf.py | 100.00% <100.00%> (ø) |
|
pyngrok/installer.py | 96.12% <100.00%> (+0.22%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d60defb...22a3513. Read the comment docs.
Added
ngrok
's tunnel definitions when calling ngrok.connect(). If a tunnel definition inngrok
's config matches the givenname
, it will be used to start the tunnel.ngrok
tunnel definition named "pyngrok-default" when calling ngrok.connect(). Whenname
isNone
and a "pyngrok-default" tunnel definition exists itngrok
's config, it will be used.ngrok
is already running without also implicitly starting it.ngrok
andpyngrok
versions in a tuple.conf.DEFAULT_PYNGROK_CONFIG
.conf.DEFAULT_PYNGROK_CONFIG
.data
to NgrokTunnel, which holds the original tunnel data.Changed
str
of the public URL. The returnedNgrokTunnel
has a reference to the previously returnedpublic_url
in it.port
(the first arg) toaddr
to matchngrok
's documentation.options
kwarg should now be unpacked, pass each option directly to the method as a kwarg.__init
__()'s params (data
,pyngrok_config
, andapi_url
) are now required.ngrok.disconnect()
no longer installs and startsngrok
, it simply returns if thengrok
process has not been started.conf.DEFAULT_PYNGROK_CONFIG
toconf._default_pyngrok_config
(use conf.set_default() instead).ngrok.ensure_ngrok_installed()
tongrok.install_ngrok()
.ngrok.install_ngrok()
(formerlyngrok.ensure_ngrok_installed()
) changed its signature, now takes apyngrok_config
(optional) instead ofngrok_path
as its only arg.process._ensure_path_ready()
toprocess._validate_path()
.Removed
pyngrok
with Python 2.7, pinpyngrok>=4.1,<4.2
.