search

alexdovzhanyn / AlchemyVM

WebAssembly Virtual Machine Built In Elixir
MIT License
189 stars 5 forks source link

get_global no implemented #17

Closed olafura closed 5 years ago

olafura commented 5 years ago 
WaspVM.load_file(ref, "../AtomVM/src/AtomVM.wasm")
** (RuntimeError) Not implemented: :get_global in init expression
    (wasp_vm) lib/decoding/global_section_parser.ex:58: WaspVM.Decoder.GlobalSectionParser.evaluate_init_expr/2
    (wasp_vm) lib/decoding/global_section_parser.ex:33: WaspVM.Decoder.GlobalSectionParser.parse_entries/2
    (wasp_vm) lib/decoding/global_section_parser.ex:16: WaspVM.Decoder.GlobalSectionParser.parse/1
    (wasp_vm) lib/decoding/decoder.ex:53: WaspVM.Decoder.do_decode/2
    (wasp_vm) lib/wasp_vm.ex:41: WaspVM.load_file/2
olafura commented 5 years ago

AtomVM.zip

alexdovzhanyn commented 5 years ago

Good catch -- this is specific to init expressions, :get_global should work everywhere else -- we just didn't have a Wasm binary to reference where :get_global was being used.

We'll get this added to the next release -- let me know if you want to pick up the issue yourself, otherwise we'll handle it

alexdovzhanyn commented 5 years ago

Implemented in commits 2958052 and eca0d9e. Will be included in the next release once we're ready, I'll leave this issue open until then.

alexdovzhanyn commented 5 years ago

Fixed and released in v0.8.0