search

alexdovzhanyn / elixium_core

A privacy-preserving decentralized application network
https://www.elixiumnetwork.org/
281 stars 37 forks source link

add formatter and run mix format #34

Closed yordis closed 6 years ago

yordis commented 6 years ago

@alexdovzhanyn I can add the Travis setup but I would suggest to bumb up the version of Travis to the latest Elixir so you could take advantage of the formatter checking the errors for you.

alexdovzhanyn commented 6 years ago

It pains me to see all of these extra parentheses :confounded: but if its a more standard elixir approach then im alright with sacrificing my personal code style. And yeah @yordis we can bump both travis and elixir to 1.6 so long as you can verify that everything still works as expected. Thanks for the help!

alexdovzhanyn commented 6 years ago

@yordis let me know when you think this is ready for merge and i'll look over it once more. Looks good so far :)

yordis commented 6 years ago

@alexdovzhanyn it is good but this Travis will fail 😄Credo it is already complaining

yordis commented 6 years ago

@alexdovzhanyn hey mate,

you can merge this, there is some recommendations from Credo that I do not want to fix because I dont want to break anything but take a look.