search

alexdresko / HSPI

HomeSeer plugin helper framework
MIT License
11 stars 11 forks source link

Bring in changes from forks #89

Open alexdresko opened 6 years ago

alexdresko commented 6 years ago

Summary

Looks like @zimmer62 forked and didn't PR back to this repo. It would help if someone could determine if the changes need to be brought back into this repo. And, if so, create the PR. Here's the link to his commit:

https://github.com/zimmer62/HSPI/commit/356e0ebca5321689d9288b26de5c0e5a15529a87

alekslyse commented 6 years ago

From what I can see you already pulled Connector.cs (btw, thats also related to to issues with the "Test Plugin" cmd writeline so maybe remove that line

The other one since its just to small changes so should not be a large change?

alexdresko commented 6 years ago

@alekslyse I spent some time really looking at his code, and I think I've extracted the goal of his changes. Don't really know why he wanted those properties public, but I'm fine with it. See https://github.com/alexdresko/HSPI/pull/94 if you'd like to provide feedback. @zshall will also review the PR before it gets merged.

zimmer62 commented 6 years ago

I don't have any memory of what or why I made any changes. I thought we talked about it, but it was a lifetime ago for me.

alexdresko commented 6 years ago

No worries. I think I figured it out. Just duking it out with @zshall over some variable naming. :)