search

alexduryee / timetwister

Powerful Ruby date parser
MIT License
34 stars 6 forks source link

Duplicate Keys in Hash throw a warning #11

Open nodanaonlyzuul opened 7 years ago

nodanaonlyzuul commented 7 years ago

Starting a rails (3.2) app using Ruby 2.2 output the following:

yada/yada/yada/.rvm/gems/ruby-2.2.6@gemsetname/gems/timetwister-0.2.5/lib/timetwister/utilities.rb:124: warning: duplicated key at line 138 ignored: "marzo"
yada/yada/yada/.rvm/gems/ruby-2.2.6@gemsetname/gems/timetwister-0.2.5/lib/timetwister/utilities.rb:129: warning: duplicated key at line 143 ignored: "agosto"
yada/yada/yada/.rvm/gems/ruby-2.2.6@gemsetname/gems/timetwister-0.2.5/lib/timetwister/utilities.rb:118: warning: duplicated key at line 146 ignored: "novembre"
yada/yada/yada/.rvm/gems/ruby-2.2.6@gemsetname/gems/timetwister-0.2.5/lib/timetwister/utilities.rb:112: warning: duplicated key at line 154 ignored: "mai"

I know those month names exist in multiple languages but maybe you can move it to a unique key with a comment letting folks know the languages.

alexduryee commented 7 years ago

Sounds like a plan; I'll remove it from redundant languages and note the gap.