Closed lcgodoy closed 5 years ago
Merging #8 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #8 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 692 697 +5
=====================================
+ Hits 692 697 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/DistanceDist.h | 100% <100%> (ø) |
:arrow_up: |
src/DistanceFactory.cpp | 100% <100%> (ø) |
:arrow_up: |
R/parDist.R | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update edd7d50...81e81ee. Read the comment docs.
@lcgodoy Thanks for your contribution! Except for some minor issues, it looks good:
src/parallelDist.so
, can put it in .gitignore
DESCRIPTION
and Readme
to Supports 40 predefined distance measures ...
Nice, @alexeckert! I'll fix it as soon as possible.
Thanks, please be aware that the src/parallelDist.so
binary is still included.
Sorry, I included it in .gitignore
but forgot to delete.
Hey, @alexeckert! :smile: Firstly, Congrats for your job in this package! It is amazing! :confetti_ball:
I included the cosine similarity in the package. I followed the pattern of making it a distance.
Also, I added it to the documentation and made the necessary modifications on
testMatrixDistances.R
. It passed both ontestthat
verifications, except for the all zeros matrix. Because it implies division by zero. Theproyx
package deals with it assuming these values equal to zero. :heavy_check_mark:I hope you appreciate it!