alexed1 / LightningFlowComponents

A collection of unofficial Flow extensions that can be used to enhance Salesforce Flow and Orchestrator.
http://unofficialsf.com
Other
576 stars 574 forks source link

Action failed: LightningLookup$controller$hover [$ is not defined] #28

Closed ejohnsonrs closed 6 years ago

ejohnsonrs commented 6 years ago

I'm getting this error when I open my flow. Do I need to set a value somewhere?

Action failed: flowcomponents:LightningLookup$controller$hover [$ is not defined] Failing descriptor: {flowcomponents:LightningLookup$controller$hover}

kensation commented 6 years ago

This is because jQuery was not included in some of the published packages. It looks like Mr. Edelstein just released an updated package for Summer 18. I just re-installed the spring 18 package and I am still getting the same error.

@alexed1 Can you double check the spring package again?

rickzaragoza commented 6 years ago

@alexed1 First let me say, Lightning Flow.net is an incredible resource I'm very grateful. However, I just installed the Summer 18 Package and I am getting the same error as well but only if I add the flowcomponents:lookupFSC lightning component to a screen and navigate to the screen then it remains on all screens I navigate to after that. Any help would be greatly appreciated. This will be a huge game changer for us thanks!

RurouniQ commented 6 years ago

I am also still getting this error TODAY, after the jQuery fix, clicking the Summer 18 installation link.

ejohnsonrs commented 6 years ago

@alexed1 our developer looked at this today and says even though jquery is included, it is not loading. He says line should say: rather than

Since it's a managed package, we can't make the change ourselves. Is this something you can easily change for us so we can re-install?

alexed1 commented 6 years ago

Good spot.

It’s not a managed package. The code is here. https://github.com/alexed1/LightningFlowComponents/tree/master/flow_screen_components/lookupFSC Would it be possible for your dev to create a pull request?

On Thu, Jun 7, 2018 at 6:25 AM ejohnsonrs notifications@github.com wrote:

@alexed1 https://github.com/alexed1 our developer looked at this today and says even though jquery is included, it is not loading. He says line should say: rather than <ltng:require scripts="/resource/jQuery_LookupCmp/jQuery1_11_2.js"/>

Since it's a managed package, we can't make the change ourselves. Is this something you can easily change for us so we can re-install?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/28#issuecomment-395418936, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_tE8P3_p4sfIwd4PEuAf9rxlD-f50Bks5t6SmsgaJpZM4UZURx .

-- Alex Edelstein Salesforce

Sent from phone. This means that my answers may seem a little terse and have weird stuff.

RurouniQ commented 6 years ago

When installed from the link on lightningflow.net, it's definitely a managed package. ☹️ image

alexed1 commented 6 years ago

Ah, right. I'm experimenting with publishing these as managed packages and lookup is the first experiment.

However, that doesn't change my prescription: Have your dev clone the repo, make the change, and push a pull request. I'll then merge in the pull request and publish a new package.

Why ask your dev to do it instead of doing it myself The great thing about community code is that it doesn't get bottlenecked behind one person. I just don't enough personal hours outside of work to maintain all of the components myself. (and as you can see, I'm not doing a good enough job of testing the changes I do make) But if everyone pitches it to implement fixes, we can improve this and other components at a very good clip.

cgerth commented 6 years ago

This is a fantastic component. Much better than the Synebo one, which was also a great effort. Is there a workaround for this error or a timeline to get that new managed release updated?

alexed1 commented 6 years ago

Ok, just published a new version with a couple fixes, including Eric's fix above. The jquery hover problem should be fixed properly this time.

sfdc-luke commented 6 years ago

Hi @alexed1, I installed the managed package yesterday and this still had the jQuery / static resource loading issue.

RurouniQ commented 6 years ago

It's working for me when I uninstalled the package and reinstalled it. Though I had to remove the component from my flows before I could uninstall the package, which is super painful.

cgerth commented 6 years ago

I tried installing the new package of this amazing component, and there was no improvement. Then I went through the incredibly painful process of removing all instances of the component from my flows (there were a lot), uninstalled it, then reinstalled it, and there was still no improvement. Then I even went through the additional step of commenting out line 18 as described above and replacing it with the version, and there's still no improvement. Just to be safe, I tried it on other browsers. What I'm seeing is that the lookup pulldown opens up only half a line, but doesn't return possible matches like it should. See screenshot. The one upside of the uninstall/reinstall is that I no longer see the jquery error at the bottom of the flow. It just ...still doesn't work.

screenshot 2018-06-14 22 09 35
alexed1 commented 6 years ago

Might now be a config error. Can you post how you have it configured?

On Thu, Jun 14, 2018 at 8:14 PM cgerth notifications@github.com wrote:

I tried installing the new package of this amazing component, and there was no improvement. Then I went through the incredibly painful process of removing all instances of the component from my flows (there were a lot), uninstalled it, then reinstalled it, and there was still no improvement. Then I even went through the additional step of commenting out line 18 as described above and replacing it with the <ltng:require scripts="{!$Resource.jQuery_LookupCmp + '/jQuery1_11_2.js'}"/> version, and there's still no improvement. Just to be safe, I tried it on other browsers. What I'm seeing is that the lookup pulldown opens up only half a line, but doesn't return possible matches like it should. See screenshot. The one upside of the uninstall/reinstall is that I no longer see the jquery error at the bottom of the flow. It just ...still doesn't work. [image: screenshot 2018-06-14 22 09 35] https://user-images.githubusercontent.com/15639342/41448450-3ef7f432-7020-11e8-88bb-2e086bf53c75.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/28#issuecomment-397501096, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_tEzETSzrzT8dtlLbRV82ciI1NwJOMks5t8yaSgaJpZM4UZURx .

-- Alex Edelstein Salesforce

Sent from phone. This means that my answers may seem a little terse and have weird stuff.

cgerth commented 6 years ago

I had a Where clause but took it out in case it was causing the lookup to return nothing. Currently it looks like this and I get that half-opened lookup results pulldown:

screenshot 2018-06-15 09 41 15 screenshot 2018-06-15 09 41 22
alexed1 commented 6 years ago

You need to specify the Display Which Field attribute so the control knows what to show. Usually this will be: "Name"

On Fri, Jun 15, 2018 at 7:43 AM cgerth notifications@github.com wrote:

I had a Where clause but took it out in case it was causing the lookup to return nothing. Currently it looks like this and I get that half-opened lookup results pulldown:

[image: screenshot 2018-06-15 09 41 15] https://user-images.githubusercontent.com/15639342/41473975-6a510c26-7080-11e8-8cf2-800c37245741.png

[image: screenshot 2018-06-15 09 41 22] https://user-images.githubusercontent.com/15639342/41473974-6a40c870-7080-11e8-9a66-03c035a3ac37.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/28#issuecomment-397644004, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_tE-efjq4b4EeT1XaFeHQ-MVrdKc6_ks5t88gJgaJpZM4UZURx .

-- Alex Edelstein Sr. Dir. Product Management - Lightning Flow and Einstein Next Best Action Salesforce.com

http://smart.salesforce.com/sig/aedelstein//us_mb/default/link.html

alexed1 commented 6 years ago

Hmm, no. Name seems to be set as default. So that's not the problem....

alexed1 commented 6 years ago

Ok, so the problem you were encountering was because you aren't specifying this attribute:

label="I4_Output Which Field as Value?"

There was a default value for this in the code but it was incorrect. I've changed the default value to "Id" so that it's no longer essential to set an input value for this one, and published a new version. The new version also addresses the ongoing jquery issue once and for all. https://sites.google.com/view/flowunofficial/flow-screen-components/lookup