alexedwards / argon2id

Argon2id password hashing and verification for Go
MIT License
452 stars 44 forks source link

replace Parallelism with number of cores #21

Closed the-hotmann closed 9 months ago

the-hotmann commented 10 months ago

Parallelism should not be hardcoded but should be dynamically set to the number of cores, that are available for the application. Also update README.

alexedwards commented 10 months ago

Thanks, this looks good and seems like a reasonable change to make. The only issue I can see is that the runtime import in the first README example isnt necessary.

Could you remove that please? Then I'll get this merged 👍🏻

the-hotmann commented 9 months ago

True, sorry my mistake. Should be removed now. Thanks for the feedback!

alexedwards commented 9 months ago

Perfect, thanks!