search

alexedwards / scs

HTTP Session Management for Go
MIT License
2.05k stars 165 forks source link

Bump pgx from v4 to v5 #157

Closed zaeph closed 1 year ago

zaeph commented 1 year ago

pgxpool@v5 uses New() instead of Connect() to create the pool.

The tests still pass, and everything seems to be working in a project using it (snippetbox in Let’s Go).

This is my first PR to a Go project, so please let me know if I’ve done anything wrong. go.sum seems to have been changed a lot.

chriswhiteoco commented 1 year ago

I was just about to do this same thing. Please accept this pull request.

alexedwards commented 1 year ago

@zaeph Thanks : )

Could you possibly reflect these changes in the README file to complete the PR?

zaeph commented 1 year ago

Could you possibly reflect these changes in the README file to complete the PR?

Sure, I’ll have a look now.

zaeph commented 1 year ago

I think a82c3af678916973705c22dd385ac2660817bf28 was the only mention. The other hits for v4 in the repo are because gormstore depends on pgx@v4.

alexedwards commented 1 year ago

@zaeph Thanks!