search

alexedwards / scs

HTTP Session Management for Go
MIT License
2.02k stars 165 forks source link

2.7.0 breaks websocket compatibility #196

Closed shlomimatichin closed 5 months ago

shlomimatichin commented 5 months ago

this patch: https://github.com/alexedwards/scs/commit/62e546ce9d2d95a370da0629bd877d9e0c4ed9a0 removed the "Hijack" method, which is required to be able to escalate http 1.1 connection to websocket. after upgrading, we now get: "websocket: response does not implement http.Hijacker", some googling relevant links: https://stackoverflow.com/questions/62980183/response-does-not-implement-http-hijacker we are downgrading for now.

alexedwards commented 5 months ago

Dupe of https://github.com/alexedwards/scs/issues/188

alexedwards commented 5 months ago

See response in https://github.com/alexedwards/scs/issues/188#issuecomment-1925412377