alexedwards / scs

HTTP Session Management for Go
MIT License
2.13k stars 166 forks source link

bufferedResponseWriter doesn't implement hijack #69

Closed xuo closed 5 years ago

xuo commented 5 years ago

It seems like a previous fixed issue with the hijack interface in the response writer raised in #11 (addressed by #12), was lost during a refactor. See: https://github.com/alexedwards/scs/commit/688d5d4cd05d460a3f0fb5826794ac134c7e039c#diff-1597ca1e1da742882a3a0804cc9f9b31L107

Would be awesome to have this reimplemented, since this issue prevents websocket upgrades.