search

alexedwards / scs

HTTP Session Management for Go
MIT License
2.09k stars 166 forks source link

Implement customizable per-session persistance #80

Closed lafriks closed 4 years ago

lafriks commented 4 years ago

Fixes #71

lafriks commented 4 years ago

Conflict resolved. Is there anything else needs to be done?

lafriks commented 4 years ago

@alexedwards friendly ping ;)

1gm commented 4 years ago

This would be a breaking change to the Codec interface and require a major version bump. Maybe this and #81 belong in v3?

alexedwards commented 4 years ago

Sorry, I've not been ignoring this, but considering it.

As this is a breaking change to the Store interface I wouldn't want to merge this right now anyway, and would prefer to wait until there are a number of breaking changes that can all be implemented together in one new release.

But I don't think it's the right solution to the problem anyway. It's probably better to add a single mechanism for overriding any setting on a per-session basis, rather than doing just the Persist setting.

I've opened issue #85 to track that.