alexei-led / pumba

Chaos testing, network emulation, and stress testing tool for containers
Apache License 2.0
2.78k stars 195 forks source link

Update docker engine to allow cleanup #167

Closed chuckkQ closed 4 years ago

chuckkQ commented 4 years ago

This MR updates the docker engine so we can use NewClientWithOpts and version negotiation so that cleaning up the tc containers works. Previously, we were using the default version of the docker API, 1.23, where cleanup with AutoRemove as a Docker Host Config is overridden to false by the Docker engine and does not actually clean anything up.

With this MR we get version negotiation so that it will select the appropriate version of the Docker API to match the Docker version of where Pumba is being ran so there will be both explicit compatibility and the ability for the containers to be cleaned up so long as Docker is > 1.13.0.