search

alexei-led / pumba

Chaos testing, network emulation, and stress testing tool for containers
Apache License 2.0
2.75k stars 193 forks source link

Couple of new issues with new release of golang-ci-lint (1.53.0) #248

Closed aminvakil closed 1 year ago

aminvakil commented 1 year ago

With the release of https://github.com/golangci/golangci-lint/releases/tag/v1.53.0 testing pumba with golang-ci-lint is producing new errors:

pkg/container/docker_client.go:14:2: import 'github.com/docker/docker/api/types' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types"
    ^
pkg/container/docker_client.go:15:2: import 'github.com/docker/docker/api/types/container' is not allowed from list 'Main' (depguard)
    ctypes "github.com/docker/docker/api/types/container"
    ^
pkg/container/docker_client.go:16:2: import 'github.com/docker/docker/api/types/filters' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types/filters"
    ^
pkg/container/docker_client.go:17:2: import 'github.com/docker/docker/api/types/mount' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types/mount"
    ^
pkg/container/docker_client.go:18:2: import 'github.com/docker/docker/client' is not allowed from list 'Main' (depguard)
    dockerapi "github.com/docker/docker/client"
    ^
pkg/container/docker_client.go:19:2: import 'github.com/docker/go-connections/nat' is not allowed from list 'Main' (depguard)
    "github.com/docker/go-connections/nat"
    ^
pkg/container/docker_client.go:20:2: import 'github.com/pkg/errors' is not allowed from list 'Main' (depguard)
    "github.com/pkg/errors"
    ^
pkg/container/docker_client.go:21:2: import 'github.com/sirupsen/logrus' is not allowed from list 'Main' (depguard)
    log "github.com/sirupsen/logrus"
    ^
pkg/container/http_client.go:11:2: import 'github.com/pkg/errors' is not allowed from list 'Main' (depguard)
    "github.com/pkg/errors"
    ^
pkg/container/mockengine_responses.go:4:2: import 'github.com/docker/docker/api/types' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types"
    ^
pkg/container/mockengine_responses.go:5:2: import 'github.com/docker/docker/api/types/container' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types/container"
    ^
pkg/container/mockengine_responses.go:6:2: import 'github.com/docker/docker/api/types/network' is not allowed from list 'Main' (depguard)
    "github.com/docker/docker/api/types/network"
    ^
pkg/container/util.go:9:2: import 'github.com/pkg/errors' is not allowed from list 'Main' (depguard)
    "github.com/pkg/errors"
    ^
pkg/chaos/command.go:8:2: import 'github.com/alexei-led/pumba/pkg/container' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/container"
    ^
pkg/chaos/command.go:10:2: import 'github.com/sirupsen/logrus' is not allowed from list 'Main' (depguard)
    log "github.com/sirupsen/logrus"
    ^
pkg/chaos/command.go:11:2: import 'github.com/urfave/cli' is not allowed from list 'Main' (depguard)
    "github.com/urfave/cli"
    ^
pkg/chaos/docker/exec.go:6:2: import 'github.com/alexei-led/pumba/pkg/chaos' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos"
    ^
pkg/chaos/docker/exec.go:7:2: import 'github.com/alexei-led/pumba/pkg/container' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/container"
    ^
pkg/chaos/docker/exec.go:9:2: import 'github.com/sirupsen/logrus' is not allowed from list 'Main' (depguard)
    log "github.com/sirupsen/logrus"
    ^
pkg/chaos/docker/kill.go:7:2: import 'github.com/alexei-led/pumba/pkg/chaos' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos"
    ^
pkg/chaos/docker/kill.go:8:2: import 'github.com/alexei-led/pumba/pkg/container' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/container"
    ^
pkg/chaos/docker/pause.go:7:2: import 'github.com/alexei-led/pumba/pkg/chaos' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos"
    ^
pkg/chaos/docker/cmd/exec.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/docker' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/docker"
    ^
pkg/chaos/docker/cmd/exec.go:10:2: import 'github.com/urfave/cli' is not allowed from list 'Main' (depguard)
    "github.com/urfave/cli"
    ^
pkg/chaos/docker/cmd/kill.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/docker' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/docker"
    ^
pkg/chaos/docker/cmd/kill.go:10:2: import 'github.com/urfave/cli' is not allowed from list 'Main' (depguard)
    "github.com/urfave/cli"
    ^
pkg/chaos/docker/cmd/pause.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/docker' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/docker"
    ^
pkg/chaos/netem/delay.go:10:2: import 'github.com/alexei-led/pumba/pkg/util' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/util"
    ^
pkg/chaos/netem/cmd/corrupt.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/netem' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/netem"
    ^
pkg/chaos/netem/cmd/delay.go:9:2: import 'github.com/alexei-led/pumba/pkg/chaos/netem' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/netem"
    ^
pkg/chaos/netem/cmd/duplicate.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/netem' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/netem"
    ^
pkg/chaos/netem/cmd/netem.go:9:2: import 'github.com/alexei-led/pumba/pkg/util' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/util"
    ^
pkg/chaos/stress/cmd/stress.go:8:2: import 'github.com/alexei-led/pumba/pkg/chaos/stress' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/stress"
    ^
cmd/main.go:15:2: import 'github.com/alexei-led/pumba/pkg/chaos/docker/cmd' is not allowed from list 'Main' (depguard)
    "github.com/alexei-led/pumba/pkg/chaos/docker/cmd"
    ^
cmd/main.go:16:2: import 'github.com/alexei-led/pumba/pkg/chaos/netem/cmd' is not allowed from list 'Main' (depguard)
    netemCmd "github.com/alexei-led/pumba/pkg/chaos/netem/cmd"
    ^
cmd/main.go:17:2: import 'github.com/alexei-led/pumba/pkg/chaos/stress/cmd' is not allowed from list 'Main' (depguard)
    stressCmd "github.com/alexei-led/pumba/pkg/chaos/stress/cmd"
    ^
cmd/main.go:19:2: import 'github.com/johntdyer/slackrus' is not allowed from list 'Main' (depguard)
    "github.com/johntdyer/slackrus"
    ^
make: *** [Makefile:123: lint] Error 2

More info: https://github.com/aminvakil/aur/actions/runs/5161283095/jobs/9298143184#step:11:178

Do you think keeping golang-ci-lint in packaging process is good for it? Or should I just remove it and forget?

alexei-led commented 1 year ago

fixed