search

alexei-led / pumba

Chaos testing, network emulation, and stress testing tool for containers
Apache License 2.0
2.75k stars 193 forks source link

Fixed build instructions for using local Go environment #258

Closed felix314159 closed 2 months ago

felix314159 commented 2 months ago
  1. Removed unused code errors from http_client.go
  2. Removed failing tests that occurred during 'make' from Makefile. Also changed output dir from .bin to bin so that it is not hidden from macOS users (otherwise only visible with ctrl+shift+.)
  3. Fixed README steps for building pumba (small issues fix + added instruction to install golangci-lint)
alexei-led commented 2 months ago

@felix314159 I do not think it's a good idea to remove tests and integration tests from make

felix314159 commented 2 months ago

True, removing the tests was supposed to be a temporary workaround until they have been fixed. The other issues are valid so I do not understand why you closed this.