search

alexei / sprintf.js

sprintf.js is a complete open source JavaScript sprintf implementation
BSD 3-Clause "New" or "Revised" License
2.11k stars 291 forks source link

Update .npmignore #204

Open pkuczynski opened 3 years ago

Nytelife26 commented 3 years ago

See #205 This removes the need for an .npmignore altogether, as it is inclusive, rather than exclusive.

pkuczynski commented 3 years ago

Yeah, it all depends on what one prefers: whitelisting or blacklisting :) There are pros and cons for both.

Nytelife26 commented 3 years ago

@pkuczynski Ultimately, for bundling, whitelisting is the way to go. If you had to package someone's order for delivery in a warehouse, would you be given a list of things they haven't ordered or a list of things they have? I appreciate the sentiment, though :)

alexei commented 3 years ago

What problem does this address?

Nytelife26 commented 3 years ago

@alexei It is unnecessary now, due to my PR. However, if you wish to investigate this too, that's fine.