alexejk / go-xmlrpc

An XML-RPC Client for Go
https://alexejk.io/article/handling-xmlrpc-in-go/
MIT License
19 stars 7 forks source link

Default to string for decoder if no explicit type is provided #76

Closed alexejk closed 10 months ago

alexejk commented 10 months ago

According to XML-RPC specification, if a value type is not provided, default should be considered as <string>. Current implementation returned nil which is not correct.

Fixes #75 - as the actual error is due to array not being properly decoded.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (317a94e) 75.09% compared to head (69e9c7f) 75.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #76 +/- ## ========================================== + Coverage 75.09% 75.38% +0.28% ========================================== Files 7 7 Lines 522 524 +2 ========================================== + Hits 392 395 +3 + Misses 100 99 -1 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication