add support of kubecolor binary

nitishkumar71 commented 5 months ago

Description

Add support of kubecolor

Motivation and Context

[x] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required) Closes #1072

How Has This Been Tested?

Executing ./arkage get kubecolor produced below output

Downloading: kubecolor
2024/06/01 19:35:05 Looking up version for kubecolor
2024/06/01 19:35:05 Found: v0.3.3
Downloading: https://github.com/kubecolor/kubecolor/releases/download/v0.3.3/kubecolor_0.3.3_linux_amd64.tar.gz
2.00 MiB / 2.00 MiB [-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
/tmp/arkade-2340145679/kubecolor_0.3.3_linux_amd64.tar.gz written.
2024/06/01 19:35:10 Extracted: /tmp/arkade-2340145679/kubecolor
2024/06/01 19:35:10 Copying /tmp/arkade-2340145679/kubecolor to /home/ubuntu/.arkade/bin/kubecolor

Wrote: /home/ubuntu/.arkade/bin/kubecolor (4.764MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/home/ubuntu/.arkade/bin/kubecolor

# Or install with:
sudo mv /home/ubuntu/.arkade/bin/kubecolor /usr/local/bin/

🚀 Speed up GitHub Actions/GitLab CI + reduce costs: https://actuated.dev

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[x] I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s

[ ] I have tested this on arm, or have added code to prevent deployment

nitishkumar71 commented 5 months ago

Just one query in the readme.

Also, the e2e tests are failing on k10multicluster because theyve renames the binary, from: https://github.com/kastenhq/external-tools/releases/download/7.0.0/k10multicluster_7.0.0_linux_amd64.tar.gz to: https://github.com/kastenhq/external-tools/releases/download/7.0.0/k10tools_7.0.0_linux_amd64.tar.gz

Do you want to fix that here too?

Apologies, I am not sure about there tooling and what purpose these binary serve. In the last release both k10tools and k10multicluster were present. Now they have dropped k10multicluster binary. If we are sure, those binary were supposed to replace each other then I can go ahead and fix it.

rgee0 commented 5 months ago

Apologies, I am not sure about there tooling and what purpose these binary serve. In the last release both k10tools and k10multicluster were present. Now they have dropped k10multicluster binary. If we are sure, those binary were supposed to replace each other then I can go ahead and fix it.

I'm no better informed, and I didn't spot the previous release had both. It looks like v7 release didn't build k10multicluster binaries. It's unfortunate that there isn't a little more detail on the repo. I'd suggest ignoring my previous message and not 'fixing' without further detail.

alexellis commented 5 months ago

These were added for @MichaelCade. We can probably drop them now given the amount of issues they've caused.

MichaelCade commented 5 months ago

Just one query in the readme.

Also, the e2e tests are failing on k10multicluster because theyve renames the binary, from: https://github.com/kastenhq/external-tools/releases/download/7.0.0/k10multicluster_7.0.0_linux_amd64.tar.gz to: https://github.com/kastenhq/external-tools/releases/download/7.0.0/k10tools_7.0.0_linux_amd64.tar.gz

Do you want to fix that here too?

These are two completely different tools

MichaelCade commented 5 months ago

These were added for @MichaelCade. We can probably drop them now given the amount of issues they've caused.

Probably remove, I have never once seen or had anyone ask anything about using arkade to deploy and these are only associated to Kasten which had a sponsored entry a few years back so these tools are only relevant to Kasten deployments.

alexellis / arkade