alexellis / arkade

Open Source Marketplace For Developer Tools
https://blog.alexellis.io/kubernetes-marketplace-two-year-update/
MIT License
4.21k stars 286 forks source link

ark get faas-cli yields 404 #173

Closed kylos101 closed 4 years ago

kylos101 commented 4 years ago

When I try to get faas-cli, I get a 404 error.

Expected Behaviour

A 200 response, with faas-cli having been successfully gotten.

Current Behaviour

ark get faas-cli
Downloading faas-cli
https://github.com/openfaas/faas-cli/releases/download/0.12.8/
Error: incorrect status for downloading tool: 404

Steps to Reproduce (for bugs)

  1. using ark 0.5.1
  2. ark get faas-cli

Context

I have to get faas-cli "the old way". ;)

Your Environment

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:51:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Linux DESKTOP-11PAHMA 4.19.84-microsoft-standard #1 SMP Wed Nov 13 11:44:37 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

NAME="Ubuntu"
VERSION="18.04.2 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.2 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic
Version: 0.5.1
Git Commit: 3c3970eafdca83570d5b1b85902a4957f9dfba16
alexellis commented 4 years ago

Oh dear, thank you for logging this. I'll take a look, do I need WSL to repro it (I see the word "Microsoft" in there)? Cc @nunix

alexellis commented 4 years ago

Can't reproduce this yet, I've tried it on MacOS:

kosmos:arkade alex$ go build && ./arkade get faas-cli
Downloading faas-cli
https://github.com/openfaas/faas-cli/releases/download/0.12.8/faas-cli-darwin
Tool written to: /var/folders/kk/7ds650y150j3b5q_t_k3q8gc0000gn/T/faas-cli-darwin

Run the following to copy to install the tool:

chmod +x /var/folders/kk/7ds650y150j3b5q_t_k3q8gc0000gn/T/faas-cli-darwin
sudo install -m 755 /var/folders/kk/7ds650y150j3b5q_t_k3q8gc0000gn/T/faas-cli-darwin /usr/local/bin/faas-cli
kosmos:arkade alex$ chmod +x /var/folders/kk/7ds650y150j3b5q_t_k3q8gc0000gn/T/faas-cli-darwin
kosmos:arkade alex$ 
kosmos:arkade alex$ /var/folders/kk/7ds650y150j3b5q_t_k3q8gc0000gn/T/faas-cli-darwin version
  ___                   _____           ____
 / _ \ _ __   ___ _ __ |  ___|_ _  __ _/ ___|
| | | | '_ \ / _ \ '_ \| |_ / _` |/ _` \___ \
| |_| | |_) |  __/ | | |  _| (_| | (_| |___) |
 \___/| .__/ \___|_| |_|_|  \__,_|\__,_|____/
      |_|

CLI:
 commit:  16f6eb9522cff9622b78cbe6450d60f8b3cd7ead
 version: 0.12.8
alexellis commented 4 years ago

Fails on standard Ubuntu x86 Linux:

alex@nuc7:~$ ./arkade-linux get faas-cli
Downloading faas-cli
https://github.com/openfaas/faas-cli/releases/download/0.12.8/
Error: incorrect status for downloading tool: 404
alex@nuc7:~$ 
nunix commented 4 years ago

Hi,

I do confirm it fails and the reason is that it fails to get the binary at the end (@alexellis in your output it's the same) image

While in your output of MacOS you have faas-cli-darwin at the end.

So "not" a WSL issue (my guess).

Waterdrips commented 4 years ago

/assign: me

I can fix this

alexellis commented 4 years ago

Fixed and released: https://github.com/alexellis/arkade/releases/tag/0.6.1

Thanks @Waterdrips

nunix commented 4 years ago

working on WSL image

great and fast work 👍

alexellis commented 4 years ago

Thank you Corsair

kylos101 commented 4 years ago

Thanks a lot, gang!