Add pr_content_check to features

burtonr commented 5 years ago

Description

This commit adds a new feature for pr_content_check This feature will verify that the incoming PR has something in the description (aka body)

If there is no description, the invalid label will be applied and a comment will be added to the PR with a link to the contributing guide.

Signed-off-by: Burton Rheutan rheutan7@gmail.com

Motivation and Context

[X] I have raised an issue to propose this change (required) Resolves #103

How Has This Been Tested?

Unit tests added and passing

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

alexellis commented 5 years ago

This is not strictly a pr_content_check (the PR being a series of commits - we don't check them at all, and this doesn't speak to how we check them) - I'd prefer to see this more descriptive such as: pr_description_required or mandatory_pr_description.

Alex

ivanayov commented 5 years ago

I would vote for pr_description_required as it's best descriptive.

burtonr commented 5 years ago

@alexellis This is ready now.

I've updated the feature name to the even better, more descriptive: pr_description_required I've addressed your comments

I've also got the version of Derek deployed and installed to test end to end on one of my repos.

PR Missing a description: screenshot from 2018-11-22 00-48-50

PR with description: screenshot from 2018-11-22 00-51-54

and finally, a PR with unsigned commits, and no description: screenshot from 2018-11-22 00-54-26

martindekov commented 5 years ago

Before this getting merged I would suggest to add pr_description_required in the .DEREK.yml file configuration of probably commented out so we know from where to manage this label

alexellis commented 5 years ago

@martindekov can we add that after the merge?

martindekov commented 5 years ago

Yeah ^ it was just suggestion

alexellis / derek