alexellis / derek

Reduce maintainer fatigue by automating GitHub
https://github.com/alexellis/derek/blob/master/USER_GUIDE.md
MIT License
806 stars 72 forks source link

Turn on validate customers and hmac by default #105

Closed martindekov closed 5 years ago

martindekov commented 5 years ago

Setting the customer validation and hmac validation on by default also moving customer validation into its own function so it can be tested more easily and extending the tests to showcase the logic the work was started by @ivanayov

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

Description

This adds more secure experience for the user so the hmac and security validation should now be turned off intentionally with explicit false or 0

Motivation and Context

Actually part of #316 issue in OpenFaaS Cloud

How Has This Been Tested?

Unit tests

Types of changes

For derek users with authentication turned off if they move to the newest version, they should explicitly set the validate_customers: 0/false and validate_hmac:0/false

Checklist: