Add namespace in secret creation - Githubissues

alexellis / derek

Reduce maintainer fatigue by automating GitHub

https://github.com/alexellis/derek/blob/master/USER_GUIDE.md

MIT License

806 stars 72 forks source link

Add namespace in secret creation #107

Closed martindekov closed 5 years ago

martindekov commented 5 years ago

Adding namespace when creating the secret since the command was invalid and misleading

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

kubectl command which creates secrets for derek was invalid (the namespace was missing)

Description

Adding default openfaas-fn namespace to the kubectl commands which created the two secrets

Motivation and Context

[ ] I have raised an issue to propose this change (required)

Didn't raise an issue due to the simplicity of the change

How Has This Been Tested?

N.A.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation update

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

martindekov commented 5 years ago

Of course !