search

alexellis / derek

Reduce maintainer fatigue by automating GitHub
https://github.com/alexellis/derek/blob/master/USER_GUIDE.md
MIT License
806 stars 72 forks source link

Refuse DCO for users.noreply.github.com #118

Closed alexellis closed 5 years ago

alexellis commented 5 years ago

Expected Behaviour

The DCO requires a valid email address and not an anonymous entity.

Current Behaviour

Some users put user@users.noreply.github.com to obstinate their real email address rendering it useless for the purposes it is required.

Possible Solution

Add the no-dco label and a comment about the use of an anonymous email.

Steps to Reproduce (for bugs)

  1. Sign off a commit as "Name user@users.noreply.github.com" and see Derek accept that
martindekov commented 5 years ago

We might send another message if noreply.github.com exists in the commit body like Thank you for the commit, but it seems like the email is anonymous...

matipan commented 5 years ago

How about:

Thank you for your contribution. I've just checked and one or more of your commits appear to be signed-off by an anonymous email. Please consider signing your commits with a valid email address. That's something we need before your Pull Request can be merged

? I'll begin making the changes to add a different message for this case :smile:

alexellis commented 5 years ago

I'd like to keep it brief and concise

matipan commented 5 years ago

PR raised: #120