search

alexellis / derek

Reduce maintainer fatigue by automating GitHub
https://github.com/alexellis/derek/blob/master/USER_GUIDE.md
MIT License
806 stars 72 forks source link

Derek marks PR with `no-dco` but the commit is signed #150

Closed rberrelleza closed 4 years ago

rberrelleza commented 4 years ago

I have a PR with two commits (https://github.com/okteto/okteto/pull/757). The 1st commit is not signed, but the second is. Even if I manually remove the no-dco label, Derek will report back saying the PR is not signed.

Expected Behaviour

When a signed commit is push, I'd expect Derek to remove the no-dco label. Or, if I remove it manuallly, I'd expect it not to be added again.

Current Behaviour

The label keeps getting added over and over.

Your Environment

or

rberrelleza commented 4 years ago

From Richard Gee:

All the commits need to be signed. The commit is the atomic unit, rather than the PR. The two commits will appear as separate commits in your history, so youd have an unsigned commit which would be contrary to the intent of requiring dco sign off.