search

alexellis / derek

Reduce maintainer fatigue by automating GitHub
https://github.com/alexellis/derek/blob/master/USER_GUIDE.md
MIT License
806 stars 72 forks source link

[Bug] Regression in authentication code #156

Closed alexellis closed 3 years ago

alexellis commented 3 years ago

Expected Behaviour

API tokens should be obtained per installation for reading beyond the 50 requests per hour limit, and for writing back to the repos where Derek is operational

Current Behaviour

The API token is not being created correctly and Derek has been broken and not operating since deploying 0.9.15 with #155

Possible Solution

Test the code change in #155 thoroughly (end to end) and fix any issues.

Steps to Reproduce (for bugs)

  1. Deploy 0.9.15
  2. Create a release and see no release notes
  3. See the rate limit printed as N/50 not N/5000
  4. Try to add a label and see it fail

Context

This will block all future PRs until fixed or reverted.

With 0.9.15

Screenshot 2020-07-23 at 09 07 28 Screenshot 2020-07-23 at 09 07 03

When reverting to previous version:

Screenshot 2020-07-23 at 09 03 36 Screenshot 2020-07-23 at 09 01 39
alexellis commented 3 years ago

@Waterdrips please take a look?

cc @martindekov

Waterdrips commented 3 years ago

apps --> app in the new url (I put apps, should have been app)

PR opened that fixes this, tested in new derek installation.

alexellis commented 3 years ago

Thank you for the quick turn-around on this Alistair 💪

Waterdrips commented 3 years ago

/close Forgot to link the close to the PR.