WIP: Move to golang-http-template

zoidyzoidzoid commented 2 years ago

Description

I've been trying to do some work on #96 and #123, but maybe I should break it up into multiple PRs.

I definitely need to test it more.

Maybe all the changes will make the most sense to do at once.

Motivation and Context

Closes https://github.com/alexellis/derek/issues/96

Might also close https://github.com/alexellis/derek/issues/123

How Has This Been Tested?

I've mainly tested this using go test but I should test it properly by actually deploying it with openfaas and things.

I thought it'd be useful to make an MR sooner rather than later, to get as much feedback and direction as possible, since I'm an openfaas noob.

Types of changes

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

This change should not break backwards compatibility or the success cases, but might subtly affect some of the error cases, if we are giving more descriptive error messages and status codes.

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 2 years ago

Thank you for your contribution. It seems that one or more of your commits have an anonymous email address. Please consider signing your commits with a valid email address. Please see our contributing guide.

alexellis commented 2 years ago

@zoidbergwill this will need some end to end testing, please see the dev guide in the repository.

faasd is probably the easiest to set up on a public cloud VM, or use inlets to connect your local OpenFaaS environment to GitHub for webhooks.

https://inlets.dev/blog/2020/10/15/openfaas-public-endpoints.html

alexellis commented 2 years ago

@zoidbergwill if you have any questions please feel free to drop by on Slack https://slack.openfaas.io in the #contributors channel

alexellis commented 2 years ago

Closing as abandoned.

zoidyzoidzoid commented 2 years ago

Sorry, I'll try pick this up again in the future.

alexellis / derek