Force local headings to over-ride remote

Signed-off-by: Richard Gee richard@technologee.co.uk

Description

The intended mode of operation for the Issue template headings was for the local to over-ride the remote. This is different to the other fields, such as maintainers.

This change adds the test to highlight the issue and addresses the issue in MergeDerekRepoConfigs.

Motivation and Context

A recent issue (https://github.com/alexellis/go-execute/issues/10) indirectly highlighted that the merging of local and remote configs was producing a superset which included duplicate headings

How Has This Been Tested?

Wrote the test, and ran it:

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^Test_mergeDerekRepoConfigs_UseLocalHeadings$ github.com/alexellis/derek/types

--- FAIL: Test_mergeDerekRepoConfigs_UseLocalHeadings (0.00s)
    /Users/rgee0/go/src/github.com/alexellis/derek/types/merge_test.go:102: RequiredInIssues want [#2], but got [#1 #2 #2]
FAIL
FAIL    github.com/alexellis/derek/types    0.229s
FAIL

Note the got set is a merge of the remote and local so includes #2 twice.

Amended MergeDerekRepoConfigs() so that if required_in_issue is set locally then those values will take precedence. Re-ran the test:

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^Test_mergeDerekRepoConfigs_UseLocalHeadings$ github.com/alexellis/derek/types

ok      github.com/alexellis/derek/types    0.233s

Ran a build using the Dockerfile.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

alexellis / derek