Open rgee0 opened 6 years ago
This would be useful for us - will it be generic enough to support the requirements from Puppet?
The Puppet requirement may require a mapping:
autolabels:
- keyword: 'labelToApply'
This would provide a greater level of flexibility.
Valid YAML may be:
autolabels:
- name: keyword
value: labelToApply
Still.. let's work to an MVP before embellishing - I'll post this into the #derek channel
As a first step this looks great. We've got some other unique requirements at puppet that we may end up needing later down the track, so notifying someone on a PR if their unit test didn't pass in travis...or they've not included a puppet manifest, the puppet version, OS version in the text in their issue. Based on that we might want Derek to comment and say, you've not included this, in much the say way it responds to PRs now that don't have dco sign off
Ok.. do you have some examples of the labels you'd like @davejrt ?
Bug Enhancement Question
Those are probably the three we use most commonly.
Same here.. these are quite subjective labels though. One thing I wanted to start for OpenFaaS was labelling for different areas.
area/swarm
area/kubernetes
area/watchdog
etc
We ask for the information on the system in the issue template so the auto-labels here would be really useful from the start. (via @rgee0 )
Since Derek had some original inspiration from Docker's Poule tool by @icecrime I thought we could refer to Arnaud's concept on a keywords -> labels mapping:
https://github.com/moby/moby/blob/master/poule.yml#L23
What do we think?
I think the approach makes sense, albeit configured via the yaml for versatility
Add an
autolabels
section toDEREK.yml
so that any issues raised containing the words within this section are automatically labelled:e.g.
Also add
- autolabels
to thefeatures
section to enable/disable