alexellis / derek

Reduce maintainer fatigue by automating GitHub
https://github.com/alexellis/derek/blob/master/USER_GUIDE.md
MIT License
808 stars 70 forks source link

Remove newlines from file where webhook secret is stored #73

Closed martindekov closed 6 years ago

martindekov commented 6 years ago

We need to check if newlines are present in the file where we load our docker secrets from.Some editors may add extra newline at the end making the secret invalid.

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

Adding check to see if newlines are present in the file from which we create docker secret for derek-secret-key.

Description

Add check in main.go if newline is present in the secret string loaded from the file and if so it removes it.

Motivation and Context

It solves issue #72.

How Has This Been Tested?

Types of changes

Checklist:

alexellis commented 6 years ago

Awesome job!