Add contributing URL field to .DEREK.yml

[viveksyngh]

This commit adds contributing_url field to the .DEREK.yml file to point to contribution guide.

Signed-off-by: Vivek Singh vivekkmr45@yahoo.in

Description

Motivation and Context

• [x] I have raised an issue to propose this change (required) Fixes: #87

How Has This Been Tested?

Test result and process added in comments below.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I've read the CONTRIBUTION guide
• [x] I have signed-off my commits with git commit -s
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[alexellis]

LGTM. Can we find away to test it - or if that's too hard in the final method to figure out the URL outside and inject it then test that new method?

[viveksyngh]

I think we can write a method to figure out URL and test that method. I will try again to setup derek. Do you have any documentation for that?

[alexellis]

Documentation on how to write tests? There's lots of coverage in this project so I'd suggest copying the approach seen in another test file.

[alexellis]

Failing that ask on slack.

[viveksyngh]

Nope .. I was asking any documentation on how to setup derek ?

[viveksyngh]

Tested against this repo. https://github.com/viveksyngh/openfaas-functions for this PR https://github.com/viveksyngh/openfaas-functions/pull/3 using below derek configuration.

curators:
 - viveksyngh

features:
 - dco_check
 - comments

contributing_url: https://github.com/alexellis/derek/blob/master/CONTRIBUTING.md

[viveksyngh]

@alexellis I have also added a new function which gets contributing URL and also added the unit test for that.

[alexellis]

Awesome 🎉 !

Glad you were able to test it end-to-end like this too. Did it help having worked with GitHub Apps in OpenFaaS Cloud?

[viveksyngh]

yeah .. that's for sure. It was really helpful.

[alexellis]

Derek add label: help wanted

[alexellis]

Derek remove label: help wanted

[alexellis]

I've released and deployed Derek 0.6.2, let's try it out?

• Update faas/.DEREK.yml to add the link (raise a PR) and I'll merge
• Find an openfaas repo that uses the redirect
• Raise a PR there without a DCO and check the link to the guide