Add "config" package - Githubissues

alexellis / derek

Reduce maintainer fatigue by automating GitHub

https://github.com/alexellis/derek/blob/master/USER_GUIDE.md

MIT License

806 stars 72 forks source link

Add "config" package #93

Closed alexellis closed 5 years ago

alexellis commented 5 years ago

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

Add "config" package

Motivation and Context

[x] I have raised an issue to propose this change (required) #62

Part of the work for #62 is included here.

adds a config package and unit tests to allow Derek to be configured by a struct. The new struct reads data from env-vars and from disk including throwing errors when data is missing.
application renamed application_id (env-var)
access_token renamed personal_access_token (env-var) and documented in GET.md
godoc added to packages / functions
unit tests added for hmacValidation() method
minor version of Golang SDK bumped in Dockerfile

How Has This Been Tested?

Tested through unit tests and go build with Go 1.10.4

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.