search

alexellis / growlab

A global contest to grow and monitor your own food with Raspberry Pi
MIT License
442 stars 49 forks source link

Add Tech and Support for BME680 #40

Closed mtaylorsherwood closed 3 years ago

mtaylorsherwood commented 3 years ago

Add me in as a new technician for the project and apply bronze level.

Fix a small typo in the readme.

Add support for BME680 sensor.

alexellis commented 3 years ago

Thanks for the interest. I've added a note.

We will also need this for the data logger. Don't worry that it's duplicated.

Alex

mtaylorsherwood commented 3 years ago

Thanks for the feedback. Have added the sensor to the data logger as well as removing that config option for simplicity.

alexellis commented 3 years ago

@pensarguet can you take a look and compare to your own patch?

mtaylorsherwood commented 3 years ago

@pensarguet can you take a look and compare to your own patch?

I'm happy to refractor mine and tidy it up once their PR is merged in, to be honest thr history is a bit messy now

pensarguet commented 3 years ago

Hi Alex,

The code from Martyn is more complete than mine and embed the data logger and the calibration stage before getting the value. For the logic, it's similar ;-)

mtaylorsherwood commented 3 years ago

Closing so other PR's can be done and I can rebase