search

alexellis / kubetrim

Trim 📏 your KUBECONFIG automatically
MIT License
93 stars 6 forks source link

Added moving spinner to context check, since it just kinda sat there #1

Open Intelrunner opened 2 months ago

Intelrunner commented 2 months ago

I added some code that puts a spinning indicator in front of the "checking" text. When I did my initial Kubetrim sweep, it sat there for a while (I had a lot of configs). This indicator lets the user know it's actually working in the background. No actual functional changes to how it does it's thing, just this addition.

derek[bot] commented 2 months ago

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

:bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name" git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force. If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Intelrunner commented 2 months ago

Added the sign off data.

alexellis commented 2 months ago

Hi @Intelrunner can you upload an ASCII cinema showing your change?

You'll also need to use a proper email address and full name for the DCO check to pass here.

Thanks.

alexellis commented 2 months ago

Out of interest, I've not seen any hanging or delay. What did you have to do in order to create that condition?

Intelrunner commented 2 months ago

Out of interest, I've not seen any hanging or delay. What did you have to do in order to create that condition?

It was on the first run that it was seemingly "hanging" - but I also had a very large amount of configs in my file due to never cleaning it up. I'm not sure if it was because it was the first run, or maybe it was because of something else going on in my system. Not necessarily something wrong with kubetrim, more of my weak attempt at a QoL addition.

Also, passed this around at work - and everyone loved Kubetrim. Thank you for building!