search

alexellis / registry-creds

Replicate Kubernetes ImagePullSecrets to all namespaces
MIT License
336 stars 37 forks source link

Readme patch #19

Closed czomo closed 3 years ago

czomo commented 3 years ago

Description

ClusterPullSecret name needs to match regex in order to be applied.

To Reproduce

Apply to kubernetes cluster ClusterPullSecret yaml file directly from Readme.md

Expected behavior

Its changing the name of ClusterPullSecret yaml to lowercase

How Has This Been Tested?

apiVersion: ops.alexellis.io/v1
kind: ClusterPullSecret
metadata:
  name: Docker Registry
spec:
  secretRef:
    name: registry-creds-secret
    namespace: kube-system

Above yaml file is failing to be applied. Changing it to name: docker-registry solve the issue.

How are existing users impacted? What migration steps/scripts do we need?

Not required

Checklist:

I have:

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.