DRAFT: Bump registry-creds image version to 0.2.6 in manifest.yaml

RothAndrew commented 3 years ago

Description

Bump the version of ghcr.io/alexellis/registry-creds in manifest.yaml to 0.2.6

Which issue # does this fix? And was it approved before you worked on it?

Fixes #24

Checklist:

[X] Fixes issue: #24
[ ] I waited for approval before creating this PR

Note: if the PR is for a typo, please close it and raise an issue instead.

How Has This Been Tested?

I validated that the behavior experienced in #24 was not happening when running make install && make run after cloning the repository, which told me it was likely due to an old version of the controller
Indeed, the version of the controller specified in manifest.yaml was 0.2.5, when the latest version is 0.2.6.
Updating manifest.yaml to reference v0.2.6 of the controller image, and using that file when running kubectl apply fixed the issue.

How are existing users impacted? What migration steps/scripts do we need?

Users that are following the README get v0.2.5 of the controller, which does not watch for service account creation
No migration steps should be necessary

Checklist:

I have:

[X] updated the documentation and/or roadmap (if required)
[X] read the CONTRIBUTION guide
[X] signed-off my commits with git commit -s
[X] added unit tests (N/A)

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

RothAndrew commented 3 years ago

Does this version need to be changed as well? https://github.com/alexellis/registry-creds/blob/eb7d74a4c5a65704f083a996c2177f99b1679221/manifest.yaml#L12

RothAndrew commented 3 years ago

Now I'm thinking manifest.yaml is a generated file, but I don't know how to regenerate it with the new tag

alexellis / registry-creds