Closed fredleger closed 3 months ago
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.
Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.
This will only take a few moments.
First, clone your fork and checkout this branch using the git CLI.
Next, set up your real name and email address:
git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"
Finally, run one of these commands to add the "Signed-off-by" line to your commits.
If you only have one commit so far then run: git commit --amend --signoff
and then git push --force
.
If you have multiple commits, watch this video.
Check that the message has been added properly by running "git log".
I haven't run into this problem, but don't use the tool myself. I'll take it from you that you've tested this and that it fixes your issues for your company.
Do you need a release?
thanks @alexellis i confirm it's in production for a week now on 3 clusters and it does work would be nice in order to have a clear tag on the history instead of a commit id.
thanks for the great work
Description
Which issue # does this fix? And was it approved before you worked on it?
Checklist:
Note: if the PR is for a typo, please close it and raise an issue instead.
Are you a GitHub Sponsor (Yes/No?)
Pull Requests from sponsors get prioritised and a quicker response.
Check at: https://github.com/sponsors/alexellis
How Has This Been Tested?
automountServiceAccountToken: true
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s