add important newline to readme

alexellis / two-better-than-one

0 stars 1 forks source link

add important newline to readme #2

Closed Waterdrips closed 4 years ago

Waterdrips commented 4 years ago

Signed-off-by: Alistair Hey alistair@heyal.co.uk

alexellis commented 4 years ago

mergers:
 - burtonr
 - LucasRoesler
 - alexellis
 - ewilde
 - johnmccabe
 - jonatasbaldin
 - kenfdev
 - martindekov
 - matipan
 - rgee0
 - stefanprodan
 - viveksyngh
 - Waterdrips
 - utsavanand2

must_approve:
- alexellis
- LucasRoesler

This means anyone from the first group can issue the merge command, if and only if there are exactly 2 reviews in approved state from the must_approve group. If the must_approve group is empty, anyone in the mergers group can merge without an approval.

alexellis commented 4 years ago

@LucasRoesler please approve

Waterdrips commented 4 years ago

/close

LucasRoesler commented 4 years ago

so confused, i never saw the original ping for this, i only saw the close notification :( sorry