search

alexevanczuk / packs

A pure Rust implementation of packwerk, a gradual modularization tool for Ruby
MIT License
70 stars 7 forks source link

Fix stale check when deleted #186

Closed perryqh closed 5 months ago

perryqh commented 5 months ago

Background

We noticed that packs check doesn't report a violation as "stale" if the file no longer exists.

Example:

"::Item":
    violations:
    - dependency
    files:
    - packs/product_services/items/path/to/file_no_longer_exists.rb

If file_no_longer_exists.rb is deleted, pks check does not report it as stale.

Fix

Consider a violation stale if the file does not exist