search

alexeymezenin / laravel-best-practices

Laravel best practices
11.24k stars 2.37k forks source link

Interface best practice #135

Open jocelinkisenga opened 2 years ago

jocelinkisenga commented 2 years ago

What about using interface with repository classes?

JohnnyWalkerDigital commented 2 years ago

My opinion: The repository pattern is the devil and should be avoided. It's taking SOLID to unnecessary levels with an ORM framework. Otherwise just store interfaces in Contracts/

jocelinkisenga commented 2 years ago

but for me, i like using repo than interfaces

carlos-mora commented 2 years ago

We need more than "I like it". In general there is a significant positioning against repositories in Laravel, mainly because it relies in an Active record pattern, and its advantages are lost when Models are isolated in Repos. In terms of Models, Laravel's style mean the use of Concerns to compose behavoir. That means that every functionality should also be exposed explicitly in Repos, what makes things complex.

jocelinkisenga commented 1 year ago

how that things can get complex? give your real example of using repo pattern

spekulatius commented 1 year ago

Hello everyone,

adding my 2-cent to the discussion about repo patterns:

From working on a larger, aged applications with repos, the repos didn't add much benefit IMHO. The repo pattern seems to work better for frameworks without strong ORM or even completely without any ORM. With Laravel most of the value from repos comes from abstracting a few setters/getters away and being more DRY. The setters and getters are covered with Eloquent pretty good already I think. The DRY part can easily achieved with an actions nicely I would argue. Can you share where you see the advantages @jocelinkisenga?

Cheers, Peter