search

alexeymezenin / laravel-best-practices

Laravel best practices
11.37k stars 2.38k forks source link

Fix wrong return type (solves #124) #150

Closed JanKrb closed 2 years ago

JanKrb commented 2 years ago

Solves #124

I completely removed the return type specification to match the other files.

spekulatius commented 2 years ago

Hey @JanKrb

thanks for picking this up. I'm considering if it would make sense to add return types wherever possible. This follow closely with Spatie's approach. I think it was in this video. What is your take on this approach?

Cheers, Peter

JanKrb commented 2 years ago

Hey,

I totally agree with you. I only removed them because most of them don't have them either. I'll add them just now. :)

JanKrb commented 2 years ago

I added the return types for the method shown in #124 and the methods in the same section. There might be a whole lot a other methods without return type.

spekulatius commented 2 years ago

Thanks for adding it in. That's already a good step forward :+1: