search

alexeyzimarev / MassTransit.EventStoreIntegration

EventStore persistence for MassTransit
Apache License 2.0
49 stars 14 forks source link

.NET Core Build + Nuget Package #2

Closed OriginalDeveloper closed 6 years ago

OriginalDeveloper commented 6 years ago

Hello @alexeyzimarev ! I am using MassTransit in my .NET Core Service and came to the idea to use EventStore with it. As there is already an integration for it, it would be perfect to be able to use it in my .NET Core Application.

Do you plan to offer an .NET Core package?

Greetings, OriginalDeveloper

alexeyzimarev commented 6 years ago

Yes, I will do it soon. Need one myself. On Thu, 1 Mar 2018 at 19:54, OriginalDeveloper notifications@github.com wrote:

Hello @alexeyzimarev https://github.com/alexeyzimarev ! I am using MassTransit in my .NET Core Service and came to the idea to use EventStore with it. As there is already an integration for it, it would be perfect to be able to use it in my .NET Core Application.

Do you plan to offer an .NET Core package?

Greetings, OriginalDeveloper

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexeyzimarev/MassTransit.EventStoreIntegration/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ACsMVeaeY9jW_DFNNte2vM3ESm1byE9dks5taEPvgaJpZM4SY0Fg .

-- Med vennligst hilsen / Best regards, Alexey V. Zimarev

OriginalDeveloper commented 6 years ago

That was a fast reply, @alexeyzimarev 🥇

I made it able to build with VS2017 and then with the build.bat to .NET Core in my fork. https://github.com/OriginalDeveloper/MassTransit.EventStoreIntegration I am not sure, if it builds as previous at github... Have no experience with building there.

I think about creating an pull request to let it build...

alexeyzimarev commented 6 years ago

Thanks for the PR. I think for proper .NET Core support, I need to change the library to .NET Standard 2.0 and also change the project format. I will try fixing it all next week.

OriginalDeveloper commented 6 years ago

Thank you very much. I'm looking forward for that :)

alexeyzimarev commented 6 years ago

Want to let you know that the new version is .NET Standard and 4.6.1. MT is 4.0.1 and therefore my package is also 4.0.1. It uses appropriate versions of the ES client. I want to keep your PR open sicne I want to convert tests to use Docker Compose instead of the embedded ES, since embedded ES is notr available in .NET Core.

alexeyzimarev commented 6 years ago

Ah no, I though you had Docker. So I can close the PR. Sorry that I have not merged it but it was a little more than anticipated.